⚠️ No Changeset found

Latest commit: 7e4a8aa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Open in StackBlitz

npm i https://pkg.pr.new/layerchart@670

commit: 7e4a8aa

Hey @itay-grudev 👋. Thanks for the PR. What is the issue you are encountering?

ctx.config.* are the explicit props pass to <Chart> including <Chart xRange={...}>. By using ctx.config.xRange instead ctx.xRange it would not including any default xRange which in this case would be [0, width] (for radial we use [0, 2 * Math.PI])

I poked around on the PR preview and didn't see any change (better or worse) which was a little surprising.

@techniq I'm still reverse-engineering to figure it out, but I got TypeError: Cannot read properties of undefined (reading 'xRange'). I'm not sure layerchart is the issue yet.

That being said, I just thought it's strange that we check whether ctx.config.xRange is truthy, but then we use ctx.xRange.

(sorry I'm just starting my day and not caffeinated 🤣)

I'm sorry about bothering you that early. Let me get you that coffee.

And thanks for the help.

You're very generous. Thank you 🫶

btw, forgot to mention, but in the future it's best to attach a changeset to a pr (pnpm changeset) so when it is merged it will be added to the CHANGELOG and trigger the CI pipeline to cut a release to npm (after merging the release PR which accumulated these changesets).

This being a minor change with no known change might not warrant it, but always nice to capture for tracing purposes (especially if we encounter an unexpected regression).

Note: We're in the process of improving state management throughout LayerChart that will enable a lot of features and also improve testability. We also have a massive docs overhaul in progress :)